Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch ERC-1967 proxy implementation in generate command #4312

Conversation

yivlad
Copy link
Contributor

@yivlad yivlad commented Oct 2, 2024

Progresses #1931

This PR introduces generating the implementation contract ABI instead of proxy ABI in wagmi CLI.

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 5b93caf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 11:01pm

@yivlad
Copy link
Contributor Author

yivlad commented Dec 30, 2024

@tmm hello, what do I need to do to get this PR merged?

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for tryFetchProxyImplementation: true.

@tmm
Copy link
Member

tmm commented Jan 15, 2025

Closing in favor of #4507

@tmm tmm closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants